fix(add-mnemon): run mnemon setup in index.ts main(), not entrypoint.sh#2656
Open
MoonCaves wants to merge 1 commit into
Open
fix(add-mnemon): run mnemon setup in index.ts main(), not entrypoint.sh#2656MoonCaves wants to merge 1 commit into
MoonCaves wants to merge 1 commit into
Conversation
The host spawns containers with `--entrypoint bash -c 'exec bun run /app/src/index.ts'`, so the image ENTRYPOINT never runs — the setup line the skill adds to entrypoint.sh is dead code and mnemon's hooks never register. Move it to the top of main() in agent-runner/src/index.ts (the real boot path, bind-mounted fresh per spawn, no rebuild), guarded on the claude provider + binary presence. Running it there keeps the agent's heartbeat alive; running it before bun starts makes the host kill the container as orphaned before it can reply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/add-mnemonskill tells you to addmnemon setuptocontainer/entrypoint.sh, but the host overrides the image ENTRYPOINT at spawn (bash -c 'exec bun run /app/src/index.ts'), so that line never runs and mnemon's hooks never register.This moves the setup call to the top of
main()incontainer/agent-runner/src/index.ts— the actual boot path, which is bind-mounted fresh into each container (so no image rebuild). Guarded on the claude provider and the mnemon binary existing; idempotent.One gotcha I baked into the note: run it inside
main(), not the spawn command. If setup runs before bun starts, the container has no heartbeat yet and the host kills it as orphaned before it can reply.Verified end-to-end (remember + recall over Telegram).