[385] Fix for stuck consumers due to unsafe host key access #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mirceaulinic if you have a moment to review please :) |
moogzy
force-pushed
the
moogzy/fix-unsafe-host-key-access
branch
from
f978585 to
dbb723e
Compare
Vendors like IOS-XR by default send messages with no hostname. Log parsers were updated to support this. This PR fixes the server.py unsafe access for the host key in msg_dict which cause the consumer/listeners to become stuck as they are expecting messages to have a host key for lookup. Signed-off-by: Adrian Arumugam <[email protected]>
moogzy
force-pushed
the
moogzy/fix-unsafe-host-key-access
branch
from
dbb723e to
1ff10fa
Compare
mirceaulinic
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Apologies for getting back so late to you @moogzy - I've been on a sabathical for a few months.
Thank you for your submission! The changes make sense
|
No dramas @mirceaulinic I hope you had a nice break! Welcome back 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #385
Vendors like IOS-XR by default send messages with no hostname. The napalm-logs ios-xr parser was updated to support this default behaviour. However, server.py has unsafe access logic for the host key in msg_dict which can cause the consumer/listeners to become stuck as they are expecting messages to have a host key for lookup.
This PR turns makes the host key access safe and returns a default value of "unknown" if the host key doesn't exist.
Signed-off-by: Adrian Arumugam [email protected]