Skip to content

Fix #30: Create ES checkout test#59

Merged
ddstewar merged 5 commits into
devfrom
30-create-es-checkout-test
May 27, 2026
Merged

Fix #30: Create ES checkout test#59
ddstewar merged 5 commits into
devfrom
30-create-es-checkout-test

Conversation

@czogby-nasa
Copy link
Copy Markdown
Contributor

No description provided.

@czogby-nasa czogby-nasa added this to the v7.1.0 milestone May 21, 2026
@czogby-nasa czogby-nasa requested a review from ddstewar May 21, 2026 01:50
@czogby-nasa czogby-nasa self-assigned this May 21, 2026
@czogby-nasa czogby-nasa linked an issue May 21, 2026 that may be closed by this pull request
1 task
@czogby-nasa czogby-nasa marked this pull request as ready for review May 22, 2026 01:30
Copy link
Copy Markdown
Contributor

@ddstewar ddstewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically the comments are saying try to use SAMPLE_APP instead of CS

Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es.py
Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
@czogby-nasa
Copy link
Copy Markdown
Contributor Author

basically the comments are saying try to use SAMPLE_APP instead of CS

Yeah, I already considered that. I started with SAMPLE_APP. But the DeleteCDS command requires a CDS, which SAMPLE_APP does not have. So I tried to use MD, as in the TBL test, to limit the number of apps needed for the suite of cFE checkout tests. But it failed, saying that MD has a critical table and thus needs that table deleted before the CDS can be deleted.

Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
Comment thread targets/CFS/procedures/cfs_test_groups_for_cfe/cfe_es_checkout.py Outdated
@ddstewar
Copy link
Copy Markdown
Contributor

Have recent changes been executed? This is confirmed to run to completion?

@czogby-nasa
Copy link
Copy Markdown
Contributor Author

Have recent changes been executed? This is confirmed to run to completion?

Yes, except the last one, because I analyzed it and determined there's no possible way for those 2 small changes to change the outcome of the test (assuming CS is running). Why do you ask?

@ddstewar
Copy link
Copy Markdown
Contributor

Have recent changes been executed? This is confirmed to run to completion?

Yes, except the last one, because I analyzed it and determined there's no possible way for those 2 small changes to change the outcome of the test (assuming CS is running). Why do you ask?

crossing i's, dotting t's. ;)

@ddstewar ddstewar merged commit 279bfd6 into dev May 27, 2026
@ddstewar ddstewar deleted the 30-create-es-checkout-test branch May 27, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create ES checkout test

3 participants