Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS-520: Update report date issue #36

Merged
merged 2 commits into from
Mar 26, 2025
Merged

KMS-520: Update report date issue #36

merged 2 commits into from
Mar 26, 2025

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Mar 25, 2025

Overview

What is the feature?

Change Notes in report shows wrong dates

What is the Solution?

Fetch all notes and filter out instead of using update date

What areas of the application does this impact?

Concept update reports

Testing

URL to test, for example: http://localhost:4001/dev/concepts/operations/update_report?version=draft&startDate=2025-01-01&endDate=2025-03-15
report should not show dates outside of the given time interval

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@htranho htranho requested review from cgokey and mandyparson March 25, 2025 23:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (873ae24) to head (5a614f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         103      103           
  Lines        1646     1652    +6     
  Branches      385      385           
=======================================
+ Hits         1642     1648    +6     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@htranho htranho merged commit 12b9969 into main Mar 26, 2025
4 checks passed
@htranho htranho deleted the KMS-520 branch March 26, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants