Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS-522: Fixed ARN for accessing step function. #37

Merged
merged 1 commit into from
Mar 26, 2025
Merged

KMS-522: Fixed ARN for accessing step function. #37

merged 1 commit into from
Mar 26, 2025

Conversation

cgokey
Copy link
Contributor

@cgokey cgokey commented Mar 26, 2025

Overview

What is the feature?

I had some kind of circular reference when referring to the ARN for the step function. This change fixes that.

What is the Solution?

Updated serverless.yml in how it references ARN.

What areas of the application does this impact?

Deployment of this code.

Testing

The deployment should work now.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cgokey cgokey requested review from mandyparson and htranho March 26, 2025 21:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (92a42e1) to head (83369af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         120      120           
  Lines        1983     1983           
  Branches      473      473           
=======================================
  Hits         1978     1978           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cgokey cgokey merged commit c3a64cb into main Mar 26, 2025
4 checks passed
@cgokey cgokey deleted the KMS-522 branch March 26, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants