Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS-522: Update trigger lambda to not use step function but just call other lambda async. #38

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

cgokey
Copy link
Contributor

@cgokey cgokey commented Mar 26, 2025

Overview

What is the feature?

Getting a timeout when the step function calls the publish handler. Replaced the step function with a simpler asynchronous lambda call from the trigger handler.

What is the Solution?

Trigger function now invokes the publish handler asynchronous.

What areas of the application does this impact?

Calling publish handler.

Testing

Hopefully be able to call the publish handler now.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cgokey cgokey requested review from mandyparson and htranho March 26, 2025 22:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (c3a64cb) to head (b1f495a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         120      120           
  Lines        1983     1998   +15     
  Branches      473      476    +3     
=======================================
+ Hits         1978     1993   +15     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cgokey cgokey changed the title KMS-522: Putting timeout back to 900 KMS-522: Update trigger lambda to not use step function but just call other lambda async. Mar 27, 2025
@cgokey cgokey merged commit bc49b89 into main Mar 27, 2025
4 checks passed
@cgokey cgokey deleted the KMS-522 branch March 27, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants