Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Rename memory block macros #770

Closed
wants to merge 1 commit into from

Conversation

ing-eoking
Copy link
Collaborator

@ing-eoking ing-eoking commented Jun 14, 2024

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • Memory Block ๊ด€๋ จ ๋งคํฌ๋กœ ์ด๋ฆ„์„ ๊ฐ„๊ฒฐํ•˜๊ฒŒ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.
    • ๋ชจ๋“  Memory Block์— ๋Œ€ํ•œ ๊ณตํ†ต์ ์ธ ์ •๋ณด๋ฅผ ์ ‘๊ทผํ•˜๋Š” ๊ฒฝ์šฐ๋Š” MBLCK_[Name]
    • ํ•œ Memory Block์— ๋Œ€ํ•˜์—ฌ ์ ‘๊ทผํ•˜๋Š” ๊ฒฝ์šฐ๋Š” [Name]_MBLCK
  • ํ˜„์žฌ ์‚ฌ์šฉ์ค‘์ด์ง€ ์•Š์€ ๋งคํฌ๋กœ๋Š” ๋น„ํ™œ์„ฑํ™” ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.
- #define MBLCK_GET_NUMBLKS(l) ((l)->blck_cnt)
- #define MBLCK_GET_BODYLEN(l) ((l)->body_len)
  • ๋งคํฌ๋กœ ์ด๋ฆ„ ๋ณ€๊ฒฝ ์ด์œ 
    • ๊ธฐ์กด์— ๋น„ํ•ด ๊ฐ€๋…์„ฑ์ด ์ข‹์•„์ง‘๋‹ˆ๋‹ค.
    • ์ด์ „ ๋…ผ์˜์—์„œ ํ˜„์žฌ ์‚ฌ์šฉ์ค‘์ธ ๋งคํฌ๋กœ ์ด๋ฆ„๊ณผ ์‚ฌ์šฉ๋ฐฉ์‹ ๋ณ€๊ฒฝ์„ ๊ณ ๋ คํ•ด๋ณด๋ผ๋Š” ์˜๊ฒฌ์ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.

@ing-eoking ing-eoking requested a review from namsic June 14, 2024 03:00
@ing-eoking ing-eoking self-assigned this Jun 14, 2024
@jhpark816
Copy link
Collaborator

@ing-eoking
์‚ฌ์šฉ๋ฒ• ๊ฐœ์„  ์—†์ด ์ด๋ฆ„๋งŒ ๋ณ€๊ฒฝํ•˜๋Š” ๊ฒƒ์€ ํ˜„์žฌ ์˜๋ฏธ๊ฐ€ ์—†์–ด ๋ณด์ž…๋‹ˆ๋‹ค.

์‚ฌ์šฉ๋ฒ• ๊ฐœ์„ ํ•ด์•ผ ํ•  ์‚ฌํ•ญ์ด ์žˆ๋‹ค๋ฉด ์ด๋ฅผ ๊ฐœ์„ ํ•˜์‹œ๊ณ ,
์‚ฌ์šฉ๋ฒ• ๊ฐœ์„ ์— ๋”ฐ๋ผ ์ด๋ฆ„ ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•  ๊ฒฝ์šฐ์—๋งŒ ๋ณ€๊ฒฝํ•˜๋ฉด ๋ฉ๋‹ˆ๋‹ค.

@ing-eoking
Copy link
Collaborator Author

ing-eoking commented Jun 14, 2024

ํ•ด๋‹น PR์€ ์˜๊ฒฌ ํ™•์ธ์ด ๊ฐ€์žฅ ์ค‘์š”ํ–ˆ์œผ๋ฉฐ, ํฌ๊ฒŒ ์˜๋ฏธ์—†๋‹ค๋Š” ์˜๊ฒฌ์ด ๋‚˜์™”์œผ๋ฏ€๋กœ ํ•ด๋‹น PR์€ ์ข…๋ฃŒํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
๋งŒ์•ฝ ์‚ฌ์šฉ๋ฐฉ์‹์ด ๋ณ€๊ฒฝ๋œ๋‹ค๋ฉด ์ด์— ๋Œ€ํ•œ ๋‚ด์šฉ์€ #756 ์—์„œ ์–ธ๊ธ‰ํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@ing-eoking ing-eoking closed this Jun 14, 2024
@ing-eoking ing-eoking removed the request for review from namsic June 14, 2024 08:34
@ing-eoking ing-eoking deleted the macro branch June 24, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants