[Aksel.nav.no] Implemented support for new lvl 1 articles #3658
Conversation
|
KenAJoh
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for new level 1 articles in the sidebar by introducing a new "standalone" category that ensures these articles appear at the top of the sidebar. Key changes include:
- Renaming and updating sidebar types to DesignsystemSidebarSectionT.
- Adding tests to verify that standalone articles are correctly positioned and sorted.
- Updating various page components to utilize the new sidebar type.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aksel.nav.no/website/components/utils/tests/generate-sidebar.test.ts | Added tests to check ordering of standalone articles |
| aksel.nav.no/website/components/utils/generate-sidebar.ts | Updated implementation to filter, sort, and map standalone pages using the new type |
| aksel.nav.no/website/components/types/sanity-schema.ts | Replaced SidebarT with DesignsystemSidebarSectionT and adjusted related typings |
| aksel.nav.no/website/pages/* | Updated sidebar type usage in multiple page components |
| aksel.nav.no/website/components/layout/sidebar/Sidebar.tsx | Updated type definitions and removed unused code for consistency |
| aksel.nav.no/website/components/layout/templates/WithSidebar.tsx | Adjusted sidebar type and removed breadcrumb logic |
| .sort((a, b) => { | ||
| return a?.heading.localeCompare(b?.heading); | ||
| }) | ||
| .sort(sortIndex) | ||
| .sort(sortDeprecated) |
There was a problem hiding this comment.
[nitpick] Chaining multiple sort calls (first by heading, then by index, then by deprecated status) may lead to unexpected ordering, as each sort call reorders the array independently. Consider combining the comparator logic into a single sort call to ensure a stable and clear ordering.
| .sort((a, b) => { | |
| return a?.heading.localeCompare(b?.heading); | |
| }) | |
| .sort(sortIndex) | |
| .sort(sortDeprecated) | |
| .sort(combinedComparator) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
* 📝 Reposition sanity fields * ✨ Added new standalone-category to sanity docs * ✨ Added validation to make sure standalone articles dont overlap with sections * 🐛 Always error out if using standalone articles until implemented * 🔥 Removed temp removal of feature * 🐛 Check for undefined slug * [Aksel.nav.no] Implemented support for new lvl 1 articles (#3658) * ✨ Added support for new lvl 1 articles * 🧪 Added tests for new sidebar * 🔥 Removed breadcrumb from WithSidebar layout * 🐛 Revert to prod dataset
Description
This updates the actual support for new lvl 1 articles in the sidebar. You will now be able to set the category to "Frittstående" (standalone), and make the article appear at the top of all the other "Dropdown" sections in the sidebar.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")