Lagrer ned fullt periodebeløp (månedsbeløp) i tillegg til redusert beløp #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tendestad
reviewed
Dec 3, 2025
| it.getPeriode() | ||
| )).map(it -> new InntektsperiodeOgMottattTidspunkt(o.getInnsendingstidspunkt(), it)) | ||
| ).toList(); | ||
|
|
Contributor
There was a problem hiding this comment.
Ville et blitt enklere logikk under dersom vi her hadde lagd en tidslinje over siste mottatte inntekt? Det ser ut som det bare er den som har høyest mottattTidspunkt som er i bruk under.
tendestad
reviewed
Dec 3, 2025
| .max(Comparator.comparing(InntektsperiodeOgMottattTidspunkt::mottattTidspunkt)); | ||
| if (sisteMottatteInntektForPeriode.isPresent()) { | ||
| InntekterForKilde forOverlapp = finnOverlappendeInntekt(p, InntekterForKilde.forBrukersRapporterteArbeidsinntekter(sisteMottatteInntektForPeriode.get().inntektsperiode)); | ||
| resultat = resultat.crossJoin(new LocalDateTimeline<>(p, mapTilRapporterteInntekterPrType(List.of(forOverlapp)))); |
Contributor
There was a problem hiding this comment.
Det er mer effektivt å samle sammen segmentene, og så til slutt lage en tidslinje. Ikke så relevant her siden det er få perioder da, men kan være lurt å gjøre likevel i tilfelle noen kopierer kode/blir inspirert herfra senere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behov / Bakgrunn
Lagrer ned fullt beløp for bedre sporing
Løsning
Andre endringer
Skjermbilder (hvis relevant)