Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81 fish script to rust #83

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

81 fish script to rust #83

wants to merge 30 commits into from

Conversation

nazmulidris
Copy link
Owner

  • [tls] Add Rust binary to do the work of fish scripts
  • [tls] Add singleton decl macro
  • [tls] Move (graduate) create_global_singleton! to r3bl_core
  • [tls] Refactor script_utils mod to be more bash-like

@nazmulidris nazmulidris linked an issue Dec 4, 2024 that may be closed by this pull request
[tls] Add a single Rust binary (gen-certs) that does the work of the 2 fish scripts #81
Open
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch 15 times, most recently from 148599e to 39f8730 Compare December 6, 2024 00:22
@nazmulidris
[tls] Add Rust binary to do the work of fish scripts
42cff33 
- Migrate get-cfssl-binaries.fish to Rust
- Use create_global_singleton! from r3bl_core
- Refactor script helper mod to be more bash-like
- scripting.rs:
  - Extract path, directory, environment, github_api, etc modules in scripting.rs
  - Make the code idiomatic Rust
  - Add tests to each module
- Path and PathBuf
  - Use Path instead of PathBuf where possible
  - Use impl AsRef<Path> to receive arguments for max generalization for calling code
  - Use &Path instead of &PathBuf
- Use TryFrom to implement conversion from OutputFolderLocations enum to PathBuf
- Add OS specific behaviors to scripting.rs
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch from 39f8730 to 42cff33 Compare December 6, 2024 00:23
@nazmulidris
[tls] Replace env::temp_dir() with tempdir()
525e98a 
- Ensure that all the tests in scripting.rs perform clean up
  of temp folders once they are complete.
- The documentation for `tempfile` crate seems to be incorrect;
  it does not automatically clean up the tempdirs once they are
  dropped (after going out of scope). I have to delete the
  tempdirs explicitly at the end of each test.
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch 11 times, most recently from 7f8886b to a4d5374 Compare December 8, 2024 22:07
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch 27 times, most recently from 57e1162 to 581a0a2 Compare February 3, 2025 15:35
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch from 581a0a2 to cef09e2 Compare February 14, 2025 21:21
@nazmulidris nazmulidris force-pushed the 81-fish-script-to-rust branch from cef09e2 to 27f1ba7 Compare February 21, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tls] Add a single Rust binary (gen-certs) that does the work of the 2 fish scripts
1 participant
@nazmulidris