Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature added-To Delete a member's record #2

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

animeshseemendra
Copy link

@animeshseemendra animeshseemendra commented Jan 5, 2017

  • A new feature added if admin has to delete the record of a member who is no longer the member of the organisation.

@abhayraw1 abhayraw1 requested a review from dhruvhacks January 6, 2017 09:17
Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation errors-

  1. in attendance.class, line 291, '(' unbalanced.
  2. in main.cpp, case '7's '{' not closed, unplaced after break statement hence unbalancing '{ }'

Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logical error-
you considered data till specific member to be deleted is reached. Members after this required data are left in old file and get deleted!! major error.

Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attempt. Keep it up. :)

@animeshseemendra
Copy link
Author

Thank you for your review.
Sorry for the mistakes , I have updated it with the required changes.

Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the serial numbers of members after deletion. It's missing.
Secondly, display option 7 as "Delete specific member" in menu.

@animeshseemendra
Copy link
Author

Changes done
Updated serial numbers of members.
7 option is displayed as "Delete specific member"

Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last member's data get's repeated with unknown serial number after deletion of any member.

@animeshseemendra
Copy link
Author

animeshseemendra commented Feb 17, 2017

I added a feature to delete a member's record from database, but as the program was not running on my computer earlier so I was getting lots of reviews about the errors. Luckily now it runs, and I have removed all the errors that was coming. If still any error comes please notify.

@RishabhJain2018
Copy link
Member

@animeshseemendra Modify your commit message according to the feature you have added or write about it in a comment.

@animeshseemendra animeshseemendra changed the title New Feature added New Feature added-To Delete a member's record Feb 18, 2017
Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last entry in attendance record repeats itself with false serial number.

@dhruvhacks
Copy link
Member

@animeshseemendra
Old version of this module is shifted to branch v1.0. Master branch of this repository is now being prepared for v2.0. So do change the PR merge request to v1.0 branch instead of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants