Skip to content

fix: Update vendor lookup method and dependency for Debian packaging #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aquilamacedo
Copy link

Replaced import OuiLookup with from ouilookup import OuiLookup due to compatibility issues with ouilookup 0.3.1. This change ensures the project works correctly.

Additionally, introduced ieee-data for CSV access, enabling the software to function independently of the ouilookup package, crucial for Debian packaging.

Replaced 'import OuiLookup' with 'from ouilookup import OuiLookup' due to
compatibility issues with ouilookup 0.3.1. This change ensures the project
works correctly.

Additionally, introduced 'ieee-data' for CSV access, enabling
the software to function independently of the ouilookup package, crucial for
Debian packaging.

Signed-off-by: Aquila Macedo <[email protected]>
@aquilamacedo
Copy link
Author

Hi @ndejong, I hope you're doing well! I've been diligently working on packaging arpwitch for Debian and wanted to provide an update on the recent developments. In the process, I encountered a hiccup regarding the ouilookup package, which isn't packaged in Debian.

To ensure arpwitch's functionality within the Debian environment, I've implemented a crucial change by introducing a dependency on ieee-data. This addition is aimed at circumventing the unavailability of the ouilookup package and enabling arpwitch to seamlessly access the necessary CSV data from ieee-data.

These changes are pivotal to arpwitch's successful integration into the Debian ecosystem.

@ndejong
Copy link
Owner

ndejong commented Nov 23, 2023

Hi @aquilamacedo thanks for the PR.

Arpwitch does need some love to get it up-to-scratch before being Debian package repo worthy in my opinion.

I'm not super excited about the hard-coding of this in your PR

oui_path = "/usr/share/ieee-data/oui.csv"

Give me a few days (or more) to rework Arpwitch, among other things it needs some async worker magic to keep up with traffic.

I'd still value your assistance and efforts in packaging for Debian though - perhaps we can pick that up as an issue - https://github.com/ndejong/arpwitch/issues

@aquilamacedo
Copy link
Author

Hi @ndejong. Nice, I'll keep an eye out for any updates on the Arpwitch rework.. If there's anything I can do to lend a hand, just let me know. I'm here and ready to help however I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants