Undesirable onPress on mobile browsers scrolling fix #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canceling a event by moving outside from the Touchable area would not prevent the onPress event of being triggered This would affect users clicking on a Touchable by accident while scrolling up or down on mobile browsers It is probably a fix for the issue necolas#731
Where are you seeing that? |
|
Hi, the current behavior is the the same using Chrome for desktop simulating a device or on a actual device: https://imgur.com/a/wgyr9 |
|
I see, this only occurs when the Touchables are not contained within a |
|
I don't think this PR works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently canceling a event by moving outside from the Touchable area would not prevent the onPress event of being triggered
This would affect users clicking on a Touchable by accident while scrolling up or down on mobile browsers
It is probably a fix for the issue #731