feat: support deployment variables as inputs#10
Conversation
| required: false | ||
| AWS_CLOUDFRONT_DISTRIBUTION_ID: | ||
| type: string | ||
| required: false |
There was a problem hiding this comment.
the bucket and aws_cloudfront are attached to https://github.com/nelc/actions-hub/pull/10/files#diff-c80649a9b4831cd14c8699c5fdbe0cb4bb85eea9e979ecb99158b1bdd3b26b95R130-R132
AWS credentials(secrets), but in my opinion is ok to keep them in vars
There was a problem hiding this comment.
Sorry I don't understand your comment and the link redirects me to this comment
There was a problem hiding this comment.
Sorry, missed click... this only works with Cloufront using the same credentials.
actions-hub/.github/workflows/mfe-s3-bucket-deployment.yml
Lines 130 to 132 in 9f2c4e3
There was a problem hiding this comment.
yes you're right this only allows changing the cloudfront configuration in the same aws account, it's not possible to use a different aws account
2 participants
Description
This adds support for input variables. It allows using either the predefined environment configuration or custom values provided through inputs.