Merged
Conversation
johanseto
reviewed
Mar 10, 2025
mfe-s3-bucket-deployment/action.yml
Outdated
| jobs: | ||
| build: | ||
| environment: | ||
| name: ${{ github.ref_name == 'open-release/redwood.nelp' && 'prod' || 'stage' }} |
Collaborator
Author
There was a problem hiding this comment.
What do you mean by same as above? maybe some missing highlight?
There was a problem hiding this comment.
I was missing this comment
https://github.com/nelc/actions-hub/pull/3/files#r1988117316
johanseto
reviewed
Mar 10, 2025
mfe-s3-bucket-deployment/action.yml
Outdated
|
|
||
| deployment: | ||
| environment: | ||
| name: ${{ github.ref_name == 'open-release/redwood.nelp' && 'prod' || 'stage' }} |
There was a problem hiding this comment.
Suggested change
| name: ${{ github.ref_name == 'open-release/redwood.nelp' && 'prod' || 'stage' }} | |
| name: ${{ github.ref_name == inputs.prod_branch|| 'stage' }} |
Could you add the prod_branch input. I am not use if in the if block you don't need {{}}
520aef0 to
920af12
Compare
920af12 to
6be53f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new reusable workflow file for deploying MFEs to an S3 bucket across different repositories. The changes are minimal compared to the initial version; the main improvements are in naming conventions and parameter definitions.
Changes
How to Call the Workflow
Include the following snippet in your GitHub Actions workflow file to call the reusable workflow: