refactor: replace branch-based env with direct env input#8
Merged
Conversation
johanseto
approved these changes
Mar 25, 2025
johanseto
left a comment
johanseto
left a comment
There was a problem hiding this comment.
LGTM. The only thing is I want to look how you are going to manage the constraint that prod env should only deploy the prod_branch. Maybe in the caller action like this...
https://github.com/nelc/pearson_vue_engine/blob/main/.github/workflows/deploy-ecs-prod.yml#L7
Its only something to do...
Collaborator
Author
|
@johanseto I was thinking something similar, take a look at this PR and let me know if you like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
.github/workflows/mfe-s3-bucket-deployment.ymlfile to improve the deployment process by using a more flexible environment input.Improvements to deployment workflow:
PROD_BRANCHinput withENVIRONMENTto specify the deployment environment (e.g., 'prod', 'stage') instead of relying on the branch name. This change simplifies the workflow and makes it more adaptable to different environments.