Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only secondaries #396

Closed
wants to merge 26 commits into from
Closed

Read only secondaries #396

wants to merge 26 commits into from

Conversation

fiquick
Copy link
Contributor

@fiquick fiquick commented Jul 18, 2024

@fiquick fiquick changed the title create branch Read only secondaries Jul 18, 2024
@fiquick fiquick marked this pull request as ready for review September 5, 2024 11:24
Copy link
Collaborator

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Paul's comment on naming.

fiquick and others added 13 commits September 5, 2024 13:32
@fiquick
Copy link
Contributor Author

fiquick commented Sep 5, 2024

Copy link
Collaborator

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table formatting.

@fiquick
Copy link
Contributor Author

fiquick commented Sep 25, 2024

Hey Jessica! We changed all references to Secondaries to secondary instances or a secondary rather than the term Secondaries in the UI and docs

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Copy link
Collaborator

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terms primaries and secondaries are widely used in clustering, do they not apply here? But regardless, apart from that inconsistency (which can be overlooked), it looks fine!

@AlexicaWright
Copy link
Collaborator

Due to naming discussion, the content had to be rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants