ever more migrating feature toggles 8

neo4j · Aug 22, 2024 · ac49632 · ac49632
1 parent 0a89763
commit ac49632
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/...rations/src/main/java/org/neo4j/gds/applications/operations/FeatureTogglesRepository.java b/...rations/src/main/java/org/neo4j/gds/applications/operations/FeatureTogglesRepository.java
@@ -46,6 +46,12 @@ String resetAdjacencyPackingStrategy() {
         return GdsFeatureToggles.ADJACENCY_PACKING_STRATEGY.get().name();
     }
 
+    boolean resetEnableAdjacencyCompressionMemoryTracking() {
+        GdsFeatureToggles.ENABLE_ADJACENCY_COMPRESSION_MEMORY_TRACKING.reset();
+
+        return GdsFeatureToggles.ENABLE_ADJACENCY_COMPRESSION_MEMORY_TRACKING.isEnabled();
+    }
+
     boolean resetEnableArrowDatabaseImport() {
         GdsFeatureToggles.ENABLE_ARROW_DATABASE_IMPORT.reset();
 

diff --git a/...perations/src/main/java/org/neo4j/gds/applications/operations/OperationsApplications.java b/...perations/src/main/java/org/neo4j/gds/applications/operations/OperationsApplications.java
@@ -99,6 +99,10 @@ public String resetAdjacencyPackingStrategy() {
         return featureTogglesRepository.resetAdjacencyPackingStrategy();
     }
 
+    public boolean resetEnableAdjacencyCompressionMemoryTracking() {
+        return featureTogglesRepository.resetEnableAdjacencyCompressionMemoryTracking();
+    }
+
     public boolean resetEnableArrowDatabaseImport() {
         return featureTogglesRepository.resetEnableArrowDatabaseImport();
     }

diff --git a/proc/misc/src/main/java/org/neo4j/gds/FeatureToggleProc.java b/proc/misc/src/main/java/org/neo4j/gds/FeatureToggleProc.java
@@ -23,7 +23,6 @@
 import org.neo4j.gds.procedures.operations.FeatureLongValue;
 import org.neo4j.gds.procedures.operations.FeatureState;
 import org.neo4j.gds.procedures.operations.FeatureStringValue;
-import org.neo4j.gds.utils.GdsFeatureToggles;
 import org.neo4j.procedure.Context;
 import org.neo4j.procedure.Description;
 import org.neo4j.procedure.Internal;
@@ -76,6 +75,13 @@ public Stream<FeatureStringValue> resetAdjacencyPackingStrategy() {
         return facade.operations().resetAdjacencyPackingStrategy();
     }
 
+    @Internal
+    @Procedure("gds.features.enableAdjacencyCompressionMemoryTracking.reset")
+    @Description("Sets the default behaviour for enabling memory tracking during the construction of an adjacency list. That value is returned.")
+    public Stream<FeatureState> resetEnableAdjacencyCompressionMemoryTracking() {
+        return facade.operations().resetEnableAdjacencyCompressionMemoryTracking();
+    }
+
     @Internal
     @Procedure("gds.features.enableArrowDatabaseImport.reset")
     @Description("Sets the default behaviour for enabling Neo4j database import via the GDS Arrow Flight Server. That value is returned.")
@@ -145,12 +151,4 @@ public void useReorderedAdjacencyList(@Name(value = "useReorderedAdjacencyList")
     public void useUncompressedAdjacencyList(@Name(value = "useUncompressedAdjacencyList") boolean useUncompressedAdjacencyList) {
         facade.operations().setUseUncompressedAdjacencyList(useUncompressedAdjacencyList);
     }
-
-    @Internal
-    @Procedure("gds.features.enableAdjacencyCompressionMemoryTracking.reset")
-    @Description("Sets the default behaviour for enabling memory tracking during the construction of an adjacency list. That value is returned.")
-    public Stream<FeatureState> resetEnableAdjacencyCompressionMemoryTracking() {
-        GdsFeatureToggles.ENABLE_ADJACENCY_COMPRESSION_MEMORY_TRACKING.reset();
-        return Stream.of(new FeatureState(GdsFeatureToggles.ENABLE_ADJACENCY_COMPRESSION_MEMORY_TRACKING.isEnabled()));
-    }
 }
diff --git a/...s-facade/src/main/java/org/neo4j/gds/procedures/operations/OperationsProcedureFacade.java b/...s-facade/src/main/java/org/neo4j/gds/procedures/operations/OperationsProcedureFacade.java
@@ -58,6 +58,12 @@ public Stream<FeatureStringValue> resetAdjacencyPackingStrategy() {
         return Stream.of(new FeatureStringValue(canonicalStrategyIdentifier));
     }
 
+    public Stream<FeatureState> resetEnableAdjacencyCompressionMemoryTracking() {
+        var isEnabled = applicationsFacade.operations().resetEnableAdjacencyCompressionMemoryTracking();
+
+        return Stream.of(new FeatureState(isEnabled));
+    }
+
     public Stream<FeatureState> resetEnableArrowDatabaseImport() {
         var isEnabled = applicationsFacade.operations().resetEnableArrowDatabaseImport();