New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.x #5767

Open

darrellwarde wants to merge 281 commits into dev from 7.x

Contributor

darrellwarde commented Nov 8, 2024

No description provided.

changeset-bot bot commented Nov 8, 2024 •

edited

Loading

🦋 Changeset detected

Latest commit: b1698b8

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

neo4j-team-graphql added the graphql label

darrellwarde temporarily deployed to npm

November 8, 2024 13:22

— with

GitHub Actions Inactive

angrykoala temporarily deployed to npm

November 8, 2024 15:58

— with

GitHub Actions Inactive

neo4j-team-graphql removed the graphql label

angrykoala temporarily deployed to npm

November 8, 2024 16:14

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 8, 2024 16:56

— with

GitHub Actions Inactive

MacondoExpress temporarily deployed to npm

November 12, 2024 16:03

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 13, 2024 16:44

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 13, 2024 16:57

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 13, 2024 17:08

— with

GitHub Actions Inactive

angrykoala temporarily deployed to npm

November 14, 2024 12:08

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 14, 2024 16:15

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 18, 2024 11:12

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 18, 2024 15:37

— with

GitHub Actions Inactive

darrellwarde temporarily deployed to npm

November 18, 2024 15:41

— with

GitHub Actions Inactive

angrykoala added 6 commits

November 18, 2024 16:53


          Fix integration tests

021e1eb


          Update e2e tests

863163c


          Fix federation e2e tests

e8c29c7


          Add changeset

ac1fa62


          Merge remote-tracking branch 'origin/7.x' into remove-single-relation…

15bca6c

…ship


          Merge branch 'dev' into 7.x

e2337b2

angrykoala temporarily deployed to npm

November 19, 2024 15:37

— with

GitHub Actions Inactive

angrykoala and others added 7 commits

November 19, 2024 15:56


          Update unit tests

61793a2


          Fix integration tests

14f2b8c


          Update apollo subgraph compatibility tests

ed732e2


          Add node directive to apollo federation tests

f4f3f45


          POC add generic scalar filters

789be0b


          Update packages/graphql/src/schema/create-relationship-fields/create-…

…relationship-fields.ts

Co-authored-by: MacondoExpress <[email protected]>


          WIP added scalar filters in the schema

6f91207

angrykoala temporarily deployed to npm

January 24, 2025 13:13

— with

GitHub Actions Inactive

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/integration/directives/relationship/duplicate-relationship/duplicate-relationship-read.int.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/integration/directives/relationship/duplicate-relationship/duplicate-relationship-update.int.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/integration/directives/vector/vector-limit-required.int.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/integration/filtering/custom-scalar-filtering.int.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/integration/pagination/limit-required.int.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/directives/node.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/issues/873.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/limit-required.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/remove-deprecated/aggregations-deprecated-disabled.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/remove-deprecated/attribute-filtering.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/remove-deprecated/mutation-operations.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/schema/remove-deprecated/relationship-filtering.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/advanced-filtering-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/cypher-filtering-list-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/cypher-filtering-one-to-one-relationship-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/cypher-filtering-scalar-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/delete-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/delete-interface-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/node-label-interface-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/projection-deprecated.test.ts

Line 1 in 1a802c0

/*

🚫 [eslint] <@typescript-eslint/comma-dangle> _{reported by reviewdog 🐶}
Definition for rule '@typescript-eslint/comma-dangle' was not found.

graphql/packages/graphql/tests/tck/deprecated/generic-filtering/roles-deprecated.test.ts

Line 1 in 1a802c0

/*


          Merge branch 'dev' into 7.x

737c555

angrykoala temporarily deployed to npm

January 24, 2025 15:00

— with

GitHub Actions Inactive

MacondoExpress added 16 commits

January 27, 2025 18:16


          add initial validation rule to help user identify a missed @node dire…

7bc73c2

…ctive


          remove directives that in some shape or form are available outside ty…

c5e0b58

…pes annotated with the node node directive, added the nodeMissingValidation to the validation rules


          initial refactor of validation rules for directives

c14459a


          migrate coalesce validation to new structure

a35b13b


          add default validation rule

a6ddf29


          add fulltext validation rule

aaae82e


          add limit directive validation to list of rules

8fa43d7


          clean-up unused files

9cb5a3e


          fix timestamp directive validation rule

a44c640


          fix populatedBy/Timestamp validation rule

d70ca01


          remove previous populatedBy validation rule

b58165d


          clean-up the new validation rules structure

233c23a


          refactor naming on the Neo4jValidationContext

33fc67f


          add neo4j copyright header to new files

68033a0


          remove unused comment

72c9f91


          Merge remote-tracking branch 'upstream/dev' into 7.x

MacondoExpress temporarily deployed to npm

January 28, 2025 11:03

— with

GitHub Actions Inactive


          Merge branch 'dev' into 7.x

0f47f28

angrykoala temporarily deployed to npm

January 28, 2025 16:15

— with

GitHub Actions Inactive

MacondoExpress and others added 5 commits

January 29, 2025 11:54


          apply suggestion from PR

bc11e95


          resolve PR comments

4ccb9c2


          apply PR suggestions

0f5e618


          add license header

d260966


          Merge pull request #5963 from MacondoExpress/validation-refactor

b1698b8

Validation rules refactor and included new errors for when the directive node is expected but missing

MacondoExpress temporarily deployed to npm

January 29, 2025 16:48

— with

GitHub Actions Inactive

github-actions bot reviewed

View reviewed changes

packages/graphql/src/schema/validation/custom-rules/directives/authorization.ts

+                              }
+                              if (authorizationDirective.arguments?.length === 0) {
+                                  throw new DocumentValidationError(
+                                      `@${authorizationDirectiveScaffold.name} requires at least one of ${authorizationDirectiveScaffold.args.join(", ")} arguments`,

Contributor

github-actions bot Jan 29, 2025

🚫 [eslint] <@typescript-eslint/no-base-to-string> _{reported by reviewdog 🐶}
Using join() for authorizationDirectiveScaffold.args will use Object's default stringification format ('[object Object]') when stringified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet