Fix for new handshake and unit test. (#866) #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for a handshake unit test that was failing once the version was increased to 6.0. This was not actually a failing test but an error in the test itself. On the second protocol entry in sent by the 'server' it supplied a version instead of a range. This meant that under certain circumstances the test would pass, which just so happened to be the case with the current versions when the handshake was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking this across from 6.x - no need for a patch release.
Fix for a handshake unit test that was failing once the version was increased to 6.0. This was not actually a failing test but an error in the test itself. On the second protocol entry in sent by the 'server' it supplied a version instead of a range. This meant that under certain circumstances the test would pass, which just so happened to be the case with the current versions when the handshake was added.