Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ollama embedder #245

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix ollama embedder #245

merged 2 commits into from
Jan 15, 2025

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Jan 14, 2025

Description

Ollama embed method always returns a sequence of sequences, even if passed only one item. This PR addresses this.

(issue mentioned in #241)

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity: Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia requested a review from a team as a code owner January 14, 2025 19:08
Copy link
Contributor

@leila-messallem leila-messallem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎈

@stellasia stellasia merged commit ade28e2 into neo4j:main Jan 15, 2025
7 checks passed
@stellasia stellasia deleted the fix/ollama branch February 7, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants