neonvm: arm support for networking manifests #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
46fd6aa to
ecc2853
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
953dd16 to
921f9ad
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
ecc2853 to
8a7a20c
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
4 times, most recently
from
b13ee03 to
2bbdeb6
Compare
No changes to the coverage.
HTML Report |
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
8a7a20c to
3d7f393
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
2bbdeb6 to
67fec8e
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
3d7f393 to
59ccc89
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
67fec8e to
ae84971
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
4 times, most recently
from
281aa47 to
c68ad69
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
7 times, most recently
from
e03dc76 to
9bf6c24
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
3 times, most recently
from
8be9777 to
9cbd3a7
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
3 times, most recently
from
2600e2a to
2e712d7
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
2 times, most recently
from
f9e7e75 to
acd5cf6
Compare
|
@mikhail-sakhnov should this one be rebased? |
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
9cbd3a7 to
f947881
Compare
mikhail-sakhnov
changed the title
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
5 times, most recently
from
1fd63dd to
4078a5f
Compare
|
It's working in dev I'm assuming? Looks good to me though, it's basically what I imagined the change would look like. |
@edude03 yes and it is in use in CI so e2e tests from this PR already using changes. |
Omrigan
approved these changes
Jan 28, 2025
sharnoff
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM, pending two things:
- Resolving previous discussions regarding the provenance of the
neondatabase/whereaboutsandneondatabase/multus-cniimages - I'm +1 for changing
multus.yamltomultus-dev.yaml; can you either (a) make this a separate PR/commit [if using rebase], or (b) note this in the PR description? It may be an unexpected change for cluster setup that directly uses the release yamls (e.g., forcloud.git)
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
4078a5f to
9d51df9
Compare
Use multiarch image for multus and whereabouts Change nodeSelector for vxlan-controller to run on arm and amd Signed-off-by: Mikhail Sakhnov <[email protected]>
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
9d51df9 to
879a893
Compare
mikhail-sakhnov
force-pushed
the
misha/network-settings-for-local-arm
branch
from
879a893 to
0eb0665
Compare
|
Folks, I eventually decided to just use bitnami for both arm and amd dev envs, for the simplicity. @sharnoff I moved renaming of multus to multus-dev to a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add manifests for mutlus for local arm env
Modify whereabouts manifests for local arm env
Modify vxlan-controller manifests for local arm env
Modify manifests targets in Makefile
Rename neonvm/config/{multus => multus-dev}
Related to #1080