util/watch: Add relist rate limiting #736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the scheduler, we're mostly fine without this (in practice, rate of relists is quite low). This *will* be required for the autoscaler-agent as we try to use the VM spec as a source of truth; we need relist rate limiting because we need relists in order to make a consistent read of the source of truth.
|
@sharnoff to check if this is still needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be required for the autoscaler-agent as we try to use the VM spec as a source of truth (ref #350); we need relist rate limiting because we need relists in order to make a consistent read of the source of truth.
(For the scheduler, we're mostly fine without this - in practice, rate of relists is quite low.)
Like #727, marked as draft until there's a PR that actually uses it.
Also haven't tested this; need to do so before merging — some kind of ad-hoc testing like what was used for #667 should suffice.