neonvm: hacking on adding virtio-fs support #963
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on something else, I spotted this in the logs:
{"level":"dpanic","ts":"2024-06-15T18:50:47.809Z","msg":"odd number of arguments passed as key-value pairs for logging",...,"ignored key":"goroutine 501 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:24 ..."}
These were used in initial implementations of #887, but not in the final version that was merged. I must have forgotten to remove them.
virtio-fs v1.11.0 supports live migration (albeit, with some major caveats). There's maybe some cool opportunities there - figured it's worth playing around with. Current status: using current vm-deploy fails with QEMU saying Device vhost-user-fs-device is not migratable, but --only-migratable was specified We're using an old version of QEMU, but I'm not actually sure if support for migratable vhost-user fs devices has been released yet (if it's even been merged at all!). More digging required... See also https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/206 See also https://www.notion.so/neondatabase/25e6aa0142e94e8fab15fbb2ba237757 --- Also, included some fixes to issues I noticed; those will be split off into separate PRs.
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtio-fs v1.11.0 supports live migration (albeit, with some major caveats).
There's maybe some cool opportunities there - figured it's worth playing around with.
Current status: using current vm-deploy fails with QEMU saying
We're using an old version of QEMU, but I'm not actually sure if support for migratable vhost-user fs devices has been released yet (if it's even been merged at all!).
More digging required...
See also https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/206
See also https://www.notion.so/neondatabase/25e6aa0142e94e8fab15fbb2ba237757
Also, included some fixes to issues I noticed; those will be split off into separate PRs.