Fetch remote extension in ALTER EXTENSION UPDATE statements #11102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR added a GUC in the Postgres fork or If you're an external contributor, a Neon employee will assist in |
tristan957
commented
Mar 5, 2025
7887 tests run: 7502 passed, 0 failed, 385 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
cb5fb4f at 2025-03-07T20:34:59.514Z :recycle: |
|
Confirmed that this works on staging. I'll work on adding a regression test. |
MMeent
approved these changes
Mar 6, 2025
tristan957
force-pushed
the
tristan957/remote-extensions
branch
from
4b63333 to
b1a556d
Compare
tristan957
force-pushed
the
tristan957/remote-extensions
branch
from
b1a556d to
6d6a7b0
Compare
ololobus
reviewed
Mar 7, 2025
test_runner/regress/data/test_remote_extensions/test_extension/test_extension.control
Show resolved
Hide resolved
tristan957
force-pushed
the
tristan957/remote-extensions
branch
from
6d6a7b0 to
95b09a7
Compare
Previously, remote extensions were not fetched unless they were used in some other manner. For instance, loading a BM25 index in pg_search fetches the pg_search extension. However, if on a fresh compute with pg_search 0.15.5 installed, the user ran `ALTER EXTENSION pg_search UPDATE TO '0.15.6'` without first using the pg_search extension, we would not fetch the extension and fail to find an update path. Signed-off-by: Tristan Partin <[email protected]>
tristan957
force-pushed
the
tristan957/remote-extensions
branch
from
95b09a7 to
cb5fb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, remote extensions were not fetched unless they were used in some other manner. For instance, loading a BM25 index in pg_search fetches the pg_search extension. However, if on a fresh compute with pg_search 0.15.5 installed, the user ran
ALTER EXTENSION pg_search UPDATE TO '0.15.6'without first using the pg_search extension, we would not fetch the extension and fail to find an update path.