-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support opaque mode for log_newpages #8582
Draft
knizhnik
wants to merge
4
commits into
main
Choose a base branch
from
log_opaque_newpages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2108 tests run: 2039 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
bb86bd2 at 2024-08-05T12:50:57.291Z :recycle: |
ololobus
reviewed
Aug 2, 2024
vendor/revisions.json
Outdated
@@ -1,5 +1,5 @@ | |||
{ | |||
"v16": ["16.3", "b39f316137fdd29e2da15d2af2fdd1cfd18163be"], | |||
"v16": ["16.3", "2e372c392105e709cca8d9224c9c0a1fa5bd3aff"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- add a link to the corresponding Postgres PR to this PR description
- reference the issue in both PRs -- https://github.com/neondatabase/cloud/issues/15361
Cannot review the code part of the PR, so added Heikki as well
c0b8fc9
to
c82f094
Compare
c82f094
to
0f85575
Compare
This PR has been automatically marked as Draft because it was last updated 158 days ago. Please, consider closing it if it's not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DuckDB pages do not contains page header.
See https://neondb.slack.com/archives/C0799BZALLR/p1722148143356959?thread_ts=1722030414.537519&cid=C0799BZALLR
The problem: we need to wallog huge (256kb) DuckDB pages.
It is natural to use Postgres
log_newpages()
function which insert FPI record.The problem is that this function assumes that pages has Postgres PageHeader.
It is already has
std_page
parameter (wherepd_lower
,pg_upper
specify hole inside page).But even non-standard page is assumed to have PageHeader and Postgres is setting LSN for it.
So there are two other alternatives:
First looks ugly, second requires no changes in Postgres, but a lot of copy&paste of Postgres and Neon code.
Summary of changes
Add
REGBUF_OPAQUE
and pass flags towal_newpages
instead ofstd_page
parameter.Correspondent PR for Postgres:
neondatabase/postgres#456
Checklist before requesting a review
Checklist before merging