Add peripheral tests

.gitignore

@@ -1,2 +1 @@
 node_modules/
-coverage/

autoload/js_host.vim

@@ -1,5 +1,5 @@
 function! js_host#RequireJSHost(host)
-  let plugin_host = expand('<sfile>:p:h').'/index.js'
+  let plugin_host = g:node_host_dir . '/index.js'
   let args = [plugin_host]
   try
     return rpcstart(a:host.orig_name, args)

gulpfile.js

@@ -9,7 +9,7 @@ var gulp = require('gulp'),
 
     PATH = {
         src: [ 'index.js', 'gulpfile.js', 'lib/**/*.js' ],
-        test: 'test/**/*.js'
+        test: 'test/*.js'
     }
 
 if ( process.env.NODE_ENV !== 'production' ) {
@@ -22,26 +22,12 @@ if ( process.env.NODE_ENV !== 'production' ) {
     tldr = require('mocha-tldr-reporter')
 }
 
-gulp.task( 'default', [ 'watch' ] )
+gulp.task( 'default', [ 'checkstyle', 'test', 'watch' ] )
 
-gulp.task( 'test', function( done ) {
-    gulp.src( PATH.src )
-                .pipe( plumber() )
-        .pipe( istanbul({
-            includeUntested: true
-        }) )
-        .pipe( istanbul.hookRequire() )
-        .on( 'finish', function() {
-            gulp.src( PATH.test )
-                .pipe( plumber() )
-                .pipe( mocha({ reporter: tldr }) )
-                .pipe( plumber() )
-                .pipe( istanbul.writeReports({
-                    reporters: [ 'html' ]
-                }) )
-                .pipe( plumber() )
-                .on( 'end', done )
-        })
+gulp.task( 'test', function() {
+    return gulp.src( PATH.test )
+        .pipe( plumber() )
+        .pipe( mocha({ reporter: tldr }) )
 })
 
 gulp.task( 'checkstyle', function() {

lib/plugin.js

@@ -131,7 +131,6 @@ Plugin.prototype.load = function() {
         Module.prototype._compile = Plugin._compileInSandbox( sandbox )
         moduleExports = sandbox.module.require( path )
         Module.prototype._compile = oldCompile
-        console.log( moduleExports )
         return moduleExports
     }
 

package.json

@@ -27,7 +27,6 @@
   "devDependencies": {
     "chai": "^3.0.0",
     "gulp": "^3.9.0",
-    "gulp-istanbul": "^0.10.0",
     "gulp-jscs": "^1.6.0",
     "gulp-jshint": "^1.11.2",
     "gulp-mocha": "^2.1.2",

plugin/js_host.vim

@@ -1 +1,2 @@
+let g:node_host_dir = expand('<sfile>:p:h:h')
 call remote#host#Register('node', '*.js', function('js_host#RequireJSHost'))

test/.jshintrc

@@ -0,0 +1,24 @@
+{
+    "asi": true,
+    "bitwise": true,
+    "curly": true,
+    "eqeqeq": true,
+    "eqnull": true,
+    "expr": true,
+    "freeze": true,
+    "immed": true,
+    "latedef": true,
+    "noarg": true,
+    "node": true,
+    "nonew": true,
+    "quotmark": "single",
+    "undef": true,
+    "unused": true,
+
+    "globals": {
+        "describe": true,
+        "before": true,
+        "beforeEach": true,
+        "it": true
+    }
+}

test/rplugin/node/test.js/index.js

@@ -0,0 +1,25 @@
+loaded = [] instanceof Array
+globals = global
+required = require('fixture')
+console.log('ahh, silence')
+
+plugin.commandSync('JSHostTestCmd', {
+    range: '',
+    nargs: '*',
+}, function( nvim, args, range ) {
+    if ( args[0] === 'can haz response?') {
+        throw new Error('no >:(')
+    }
+    return [args, range]
+})
+
+plugin.autocmdSync('BufEnter', {
+    pattern: '*.js',
+    eval: 'expand("<afile>")'
+}, function( nvim, filename ) {
+    debug('This is an annoying function')
+})
+
+plugin.function('Func', function( nvim, args ) {
+    return 'Funcy ' + args
+})

test/rplugin/node/test.js/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "test.js",
+  "version": "1.0.0",
+  "description": "A test fixture",
+  "main": "index.js",
+  "scripts": {
+    "test": "gulp test"
+  },
+  "author": "",
+  "license": "MIT"
+}

test/test_devnull.js

@@ -0,0 +1,10 @@
+var assert = require('chai').assert,
+    DevNull = require('../lib/devnull')
+
+describe('DevNull', function() {
+    it('should be webscale', function( done ) {
+        var devnull = new DevNull()
+        assert.isNull( devnull.read(), 'Read should return null' )
+        assert.isTrue( devnull.write( 'benchmarks', done ), 'Write should succeed' )
+    })
+})

test/test_plugin.js

@@ -0,0 +1,49 @@
+var assert = require('chai').assert,
+    path = require('path'),
+    Plugin = require('../lib/plugin'),
+    PLUGIN_PATH = path.join( __dirname, 'rplugin', 'node', 'test.js' )
+
+describe('Plugin', function() {
+    var plugin
+
+    beforeEach( function() {
+        plugin = new Plugin( PLUGIN_PATH ).load()
+    })
+
+    it('should collect the specs from a plugin file', function() {
+        var exSPECted = [
+                { type: 'command', name: 'JSHostTestCmd', sync: true,
+                    opts: { range: '', nargs: '*' } },
+                { type: 'autocmd', name: 'BufEnter', sync: true,
+                    opts: { pattern: '*.js', eval: 'expand("<afile>")' } },
+                { type: 'function', name: 'Func', sync: false, opts: {} }
+            ]
+        assert.deepEqual( plugin.specs, exSPECted )
+    })
+
+    it('should collect the handlers from a plugin', function() {
+        var handlerId = [ PLUGIN_PATH, 'function', 'Func' ].join(':')
+        assert.strictEqual( plugin.handlers[ handlerId ]( null, 'town' ), 'Funcy town' )
+    })
+
+    it('should load the plugin a sandbox', function() {
+        var sandbox = plugin.sandbox
+        assert.isTrue( sandbox.loaded, 'Plugin was not loaded' )
+        assert.isUndefined( global.loaded, 'Plugin polluted host global scope' )
+        assert.notInclude( Object.keys( sandbox.process ), [ 'chdir', 'exit' ],
+                           'Plugin should not have dangerous `process` functions')
+    })
+
+    it('should load files required by the plugin in a sandbox', function() {
+        var required = plugin.sandbox.required
+        assert.strictEqual( required.loaded, 'you bet!',
+                            'require() from within a plugin failed' )
+        assert.notInclude( Object.keys( required.globals.process ), [ 'chdir', 'exit' ],
+                           'Plugin should not have dangerous `process` functions')
+    })
+
+    it('should cache loaded plugins', function() {
+        var samePlugin = new Plugin( PLUGIN_PATH ).load()
+        assert.strictEqual( plugin, samePlugin )
+    })
+})