Highlight qualified names based on last component (also highlight "XXX") #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qualified names are treated based on their last part: as an operator, identifier or typename
…into neovimhaskell-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously qualified names were matched like
Which is silly as those are not type nor operator! And I didn't like how it looked. Now such qualified names are matched as a whole.
The matching changed for HaskellType and HaskellOperator. I think HaskellKeyword need not be changed as that is only used where new keywords are defined, and you can't qualify in those places.
Also I added hightlighting for XXX like for TODO and FIXME since that is used in most other languages.