Add prune_scale3d argument to MCMCStrategy #567
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it makes things clearer, I can rename |
|
Have you ran this and seen if it fixes the issues mentioned on those datasets? |
|
@N-Demir: I only ran it on my datasets (that I can't share) and it improves the situation. Some users on the Discord server tested it and it worked for them as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCMC-based models often suffer from very large splats that reduce the overall quality, as partially discussed in #252 and nerfstudio-project/nerfstudio#3548. This PR adds the same logic as in the default strategy, that is pruning (or in this case relocating) splats that are too large. I used the same naming convention and default values as for the default strategy for consistency.