feat(skins): add Zeus skin — OLED-near-black dark surfaces with default gold accent #3328
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Zeus skin registration and dark-surface affordances.""" | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| REPO = Path(__file__).parent.parent | ||
| CSS = (REPO / "static" / "style.css").read_text(encoding="utf-8") | ||
| BOOT_JS = (REPO / "static" / "boot.js").read_text(encoding="utf-8") | ||
| CONFIG_PY = (REPO / "api" / "config.py").read_text(encoding="utf-8") | ||
| INDEX_HTML = (REPO / "static" / "index.html").read_text(encoding="utf-8") | ||
| I18N_JS = (REPO / "static" / "i18n.js").read_text(encoding="utf-8") | ||
|
Comment on lines
+5
to
+10
Contributor
Author
There was a problem hiding this comment. Matches the pattern used in every existing skin test in the repo (e.g. |
||
|
|
||
|
|
||
| def test_zeus_skin_is_registered_in_all_files(): | ||
| assert "{name:'Zeus'" in BOOT_JS | ||
| assert "zeus:1" in INDEX_HTML | ||
| assert '"zeus"' in CONFIG_PY | ||
|
|
||
|
|
||
| def test_zeus_dark_surfaces_are_near_black(): | ||
| assert ':root.dark[data-skin="zeus"]' in CSS | ||
| assert "--bg:#0F0F0F" in CSS | ||
| assert "--sidebar:#111111" in CSS | ||
| assert "--surface:#181818" in CSS | ||
|
|
||
|
|
||
| def test_zeus_preserves_default_gold_accent(): | ||
| # Zeus does NOT redefine --accent; it stays with the default gold. | ||
| # Verify gold-tinted border/focus vars are present instead. | ||
| assert "--border2:rgba(255,215,0,0.18)" in CSS | ||
| assert "--focus-ring:rgba(255,215,0,.4)" in CSS | ||
| assert "--hover-bg:rgba(255,215,0,.06)" in CSS | ||
|
|
||
|
|
||
| def test_zeus_active_session_uses_gold_highlight(): | ||
| assert ':root.dark[data-skin="zeus"] .session-item.active' in CSS | ||
| assert "border-left:2px solid #FFD700" in CSS | ||
|
|
||
|
|
||
| def test_zeus_modals_are_not_navy(): | ||
| # Modals/dialogs default to a hardcoded navy gradient — Zeus must override | ||
| assert ':root.dark[data-skin="zeus"] .app-dialog' in CSS | ||
| assert ':root.dark[data-skin="zeus"] .kanban-modal' in CSS | ||
| assert "rgba(24,24,24,.99)" in CSS | ||
|
|
||
|
|
||
| def test_zeus_i18n_lists_skin_in_all_locales(): | ||
| # Zeus is the last skin in each locale's cmd_theme string, so it appears | ||
| # as `…/zeus)` rather than `/zeus/`. There are 10 locales. | ||
| assert I18N_JS.count("zeus)") == 10 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-existing gap not introduced by this PR —
hepburnandneonare already absent fromcmd_themein current master. Addedzeusconsistently with the existing pattern. Happy to fix the broader gap in a separate PR if useful.