feat(settings): make non-WebUI sidebar session cap configurable#3347
Open
fuzhyperblue wants to merge 1 commit into
Open
feat(settings): make non-WebUI sidebar session cap configurable#3347fuzhyperblue wants to merge 1 commit into
fuzhyperblue wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
20) in both the state.db fetch path and the final sidebar visibility cap.pinned_sessions_limit).Contract Routing
Task type: small behavior extension (settings-backed numeric preference)
Touched areas: settings persistence, sidebar session merging/capping, settings UI, regression tests
Relevant public docs:
AGENTS.mdCONTRIBUTING.mddocs/CONTRACTS.mdScope boundaries:
Evidence needed before claiming done:
/api/settingsWhat Changed
Backend
cli_session_limitto_SETTINGS_DEFAULTSinapi/config.py(default20)._SETTINGS_INT_RANGES(1..500).api/models.py:_cli_visible_session_limit()helper.api/routes.py:_resolve_cli_session_cap(settings)helper.Frontend
static/index.html: added a new number input in Settings:id="settingsCliSessionLimit"static/panels.js:cli_session_limit/api/settingsstatic/boot.js:window._cliSessionLimitfrom settingsTests
tests/test_configurable_cli_session_limit.py:/api/settingspersistence and range behaviorDocs
CHANGELOG.mdupdated under[Unreleased]with the new configurable setting.Why It Matters
20).pinned_sessions_limit).Verification
pytest tests/test_configurable_cli_session_limit.py -v✅pytest tests/test_configurable_pinned_sessions_limit.py -v✅Risks / Follow-ups
Model Used