feat(workspace): drag-and-drop move within file tree (#3402)#3422
Open
pamnard wants to merge 3 commits into
Open
feat(workspace): drag-and-drop move within file tree (#3402)#3422pamnard wants to merge 3 commits into
pamnard wants to merge 3 commits into
Conversation
…esquena#3411) OS Files dropped on #fileTree bubbled to the document drop handler and also called addFiles(). Stop propagation on tree dragenter/dragover/drop.
Add POST /api/file/move and folder/breadcrumb drop targets so workspace tree items can be moved without breaking composer @path drags (nesquena#1097).
…uena#3402) Fix Korean locale parity test failure in CI shard 1.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/file/movefor cross-folder moves inside the workspace.stopPropagationso composer@pathdrags and OS file uploads stay unchanged).Test plan
uv run pytest tests/test_issue3402_workspace_tree_move.py tests/test_issue3411_workspace_tree_os_drop.py tests/test_issue1097_workspace_drag_drop.pya.txtonto a folder row → file moves, composer unchanged@path(Feature Request: Drag and Drop Files/Folders from Workspace Panel to Chat #1097)Part of #3402 (internal move). OS import polish is follow-up.
Depends on / includes #3411 (#3421).