Skip to content

docs(rfc): mark Transparent Stream RFC Accepted + spike note (#3820)#3864

Merged
nesquena-hermes merged 2 commits into
nesquena:masterfrom
franksong2702:franksong2702/rfc-transparent-stream-accepted
Jun 9, 2026
Merged

docs(rfc): mark Transparent Stream RFC Accepted + spike note (#3820)#3864
nesquena-hermes merged 2 commits into
nesquena:masterfrom
franksong2702:franksong2702/rfc-transparent-stream-accepted

Conversation

@franksong2702

Copy link
Copy Markdown
Contributor

Doc-only follow-up to #3862. No code, no behavior change.

What

  • Status: Proposed → Accepted. Direction was confirmed by @nesquena (Discord) and the RFC is merged, so the status field should reflect that.
  • Adds a spike-validation note to integration point A (the settled-rebuild path). A throwaway local prototype against master confirmed:
    • the branch is ~31 lines and needs no new dataactivityOrder is already chronologically sorted;
    • compact previews are already provided by the existing buildToolCard(tc) / _thinkingActivityNode(text) builders (acceptance criterion 3 met by existing code on this path);
    • reload/re-render consistency is free (criterion 4, settled) because the rebuild cleanup already removes .tool-card-row and .agent-activity-thinking before each render;
    • DOM insertion order, including the shared-anchor fallback case, was verified with a small node harness.

The spike was local-only and not pushed; this PR just records its conclusion so whoever implements PR-2 has it.

Scope

Doc-only. Implementation PRs still follow the rollout plan and coordinate on #3820 first.

🤖 Generated with Claude Code

…quena#3820)

Direction confirmed by @nesquena (Discord) and the RFC is merged (nesquena#3862), so
flip Status Proposed -> Accepted. Also record the settled-path spike result on
integration point A: ~31 lines, no new data, compact previews via the existing
buildToolCard, and reload consistency for free from the rebuild cleanup; DOM
insertion order verified with a node harness. Doc-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown

Greptile Summary

This doc-only follow-up updates the Transparent Stream RFC to reflect that the proposal has been accepted and records the conclusions of a local spike validation against master.

  • Status field is updated from Proposed to Accepted, citing the direction confirmation and the merged RFC PR (docs(rfc): Transparent Stream activity display mode (#3820) #3862).
  • Spike-validation note is added to integration path A (settled-rebuild), summarising the prototype findings: ~31-line branch, no new data needed, existing builders satisfy acceptance criteria 3 and 4, and DOM insertion order was verified with a node harness.

Confidence Score: 5/5

Documentation-only change with no code, runtime behaviour, or schema modifications — completely safe to merge.

The PR touches a single RFC markdown file: it updates a status field and appends a prose note recording local spike conclusions. Nothing executable changes; the spike itself was local-only and not pushed.

No files require special attention.

Important Files Changed

Filename Overview
docs/rfcs/transparent-stream-activity-mode.md Status updated from Proposed → Accepted; Updated date added; spike-validation note appended to integration path A. No code or behaviour changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Turn settles / page reloads] --> B{Transparent Stream mode?}
    B -- No --> C[Existing grouped Activity card\n_toolWorklogSummary]
    B -- Yes --> D[Integration Path A: Settled-Rebuild\nrenderMessages loop]
    D --> E[activityOrder already sorted\nchronologically]
    E --> F[buildToolCard / _thinkingActivityNode\nbuilders supply compact previews\nCriteria 3 met]
    F --> G[Cleanup removes .tool-card-row\nand .agent-activity-thinking\nCriteria 4 met — free]
    G --> H[~31-line branch\nno new data required]

    A2[Turn is live / streaming] --> B2{Transparent Stream mode?}
    B2 -- No --> C2[Old thinkingRow path\nlegacy behaviour]
    B2 -- Yes --> D2[Integration Path B: Live\nensureLiveWorklogShell\nreasoning / tool / interim_assistant handlers]
    D2 --> E2[Must NOT fall back\nto old thinkingRow]
    E2 --> F2[Transparent live branch\nstill to be implemented]
Loading

Reviews (2): Last reviewed commit: "Merge branch 'master' into franksong2702..." | Re-trigger Greptile

@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Verified doc-only and accurate. The status flip (Proposed → Accepted) reflects the direction approval, and I confirmed the spike note's cited anchors are real on master: _thinkingActivityNode (ui.js:6422), buildToolCard (9097), and the pre-render cleanup that removes .tool-card-row/.agent-activity-thinking (ui.js:5189, 8521). The spike de-risks integration point A (the highest-value settled-path slice). Merging. Thanks @franksong2702.

@nesquena-hermes nesquena-hermes merged commit c031cf5 into nesquena:master Jun 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants