fix(fastify): uppercase http method names #14017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify expects uppercase and won't auto-add the HEAD method otherwise
Closes #13016
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a
GET
endpoint is registered with Fastify, Nest responds with 404 on aHEAD
requestIssue Number: #14016
What is the new behavior?
Fastify correctly detects that the endpoint is a
GET
and auto-adds aHEAD
handler too.Does this PR introduce a breaking change?
Other information
The Fastify logic is here and you can see it expects uppercase method names:
https://github.com/fastify/fastify/blob/238d8a4f78b75c88e7b69b2d97fe27dd93fc520d/lib/route.js#L210