Support for NDFC #152
Open
skaszlik wants to merge 31 commits into
Open
Conversation
danischm
requested changes
Sep 15, 2025
- Migrate NDFC client to new controller structure using httpx - Implement MSD fabric detection and topology handling - Add VPC filtering with embedded interface data - Update CLI to support NDFC with domain and fabric_name parameters - Create comprehensive NDFC endpoints configuration - Maintain compatibility with existing VPC and MSD features
skaszlik
force-pushed
the
ndfc-support-v2
branch
from
121407a to
ee1889e
Compare
danischm
requested changes
Nov 19, 2025
danischm
requested changes
Nov 19, 2025
Author
juchowan
requested changes
Jan 16, 2026
| raise typer.Exit(1) | ||
|
|
||
| output_file = output or "nac-collector.zip" | ||
| fabric_name = os.getenv("NDFC_FABRIC_NAME") |
Contributor
There was a problem hiding this comment.
i think that should be in the ndfc code, not in the main
…le roots and improve member collection
…or improved clarity and type safety
kuba-mazurkiewicz
requested changes
Jun 12, 2026
| lib64/ | ||
| parts/ | ||
| sdist/ | ||
| var/ |
Collaborator
There was a problem hiding this comment.
is there any reason why you remove this from .gitignore? , those standard packaging ignores should be kept ignored
| def authenticate(self) -> bool: | ||
| """ | ||
| Authenticate with NDFC using the credentials provided. | ||
| Uses the /logon endpoint for NDFC authentication. |
Collaborator
There was a problem hiding this comment.
shouldn't that be /login ?
| processed_count, | ||
| ) | ||
|
|
||
| def _process_serial_interface_children( |
Collaborator
There was a problem hiding this comment.
I don't see that being referenced anywhere, looks like this code is never executed
| logger.error("Authentication error: %s", str(e)) | ||
| return False | ||
|
|
||
| def collect_data(self, endpoints_file: str) -> dict[str, Any]: |
Collaborator
There was a problem hiding this comment.
dead code, I dont see its being executed anywhere, even though NDFC Documentation.md says its EntryPOint
| raise typer.Exit(1) | ||
|
|
||
| output_file = output or "nac-collector.zip" | ||
| fabric_name = os.getenv("NDFC_FABRIC_NAME") |
|
|
||
| elif parent_name == "Discovered_Switches": | ||
| self._process_switch_interfaces(parent_endpoint, endpoint_dict) | ||
| elif parent_name in self.PORT_CHANNEL_INTERFACE_TYPES: |
Collaborator
There was a problem hiding this comment.
this code needs TrunkPort-Channel or AccessPort-Channel but i think those names will never appear cause parent_names looking at ndfc.yaml can be:
MSD_Fabric_Associations, Fabric_Configuration, Discovered_Switches,
VPC_Pairs, Policies, VRF_Configuration, Network_Configuration
so this path is never taken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for NDFC with a single fabric and MSD family.