feat(iosxe): get_excluded_features helper for SD-WAN UX 2.0#35
Open
aitestino wants to merge 1 commit into
Open
feat(iosxe): get_excluded_features helper for SD-WAN UX 2.0#35aitestino wants to merge 1 commit into
aitestino wants to merge 1 commit into
Conversation
SD-WAN UX 2.0 dual-device configuration groups assign features to
specific devices via device_tags. Each verification test that walks
configuration_groups -> feature_profiles needs to skip features
assigned to the OTHER device in the pair.
Centralize that lookup on IOSXETestBase so individual test cases
(verify_bgp_peers, verify_ospf_neighbor_state, etc.) call:
excluded = self.get_excluded_features(router, config_group)
instead of duplicating the topology_label / tags detection logic.
- 20.18+ matches by router.topology_label
- 20.15 and earlier matches by router.tags
- No device_tags or no router metadata returns empty set
- Returns set[str] for O(1) membership lookup at the call site
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
IOSXETestBase.get_excluded_features(router, config_group)so SD-WAN verification tests can support UX 2.0's excluded-feature behavior with a single call instead of inlining the dual-devicedevice_tagsfilter in each test case.router.topology_labelrouter.tagsdevice_tagsor no router metadata returns an emptyset[str]Returns
set[str]for O(1) membership at the call site.Test plan
ruff checkcleanmypycleanCo-Authored-By: Claude noreply@anthropic.com