Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay] Refactor initial Relay connection #2800

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Oct 28, 2024

Change initial Relay connection logic

Can support firewalls with restricted WS rules

  • allow to run engine without Relay servers
  • keep up to date Relay address changes

Describe your changes

  • handle thread-safe way the relay client instance
  • reimplement guard code
  • atomic store for Relay server address management
  • allow to run engine without success Relay connection
  • fix status indication
  • allow to upgrade/downgrade between ICE Turn and Relay

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

sonarcloud bot commented Oct 29, 2024

@pappz pappz marked this pull request as ready for review October 29, 2024 16:19
@lixmal lixmal self-requested a review October 29, 2024 19:49
@pappz pappz changed the title Refactor initial Relay connection [relay] Refactor initial Relay connection Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants