Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Refactor peers to use store methods #2893

Draft
wants to merge 6 commits into
base: nameserver-get-account-refactoring
Choose a base branch
from
Draft

[management] Refactor peers to use store methods #2893

wants to merge 6 commits into from

Conversation

bcmmbaga
Copy link
Contributor

@bcmmbaga bcmmbaga commented Nov 14, 2024 •
edited
Loading

Describe your changes

Remove calls to get and save whole account in peers operations.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@bcmmbaga bcmmbaga changed the base branch from main to dns-get-account-refactoring November 14, 2024 16:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@bcmmbaga bcmmbaga changed the base branch from dns-get-account-refactoring to nameserver-get-account-refactoring November 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcmmbaga