Skip to content

Requirements.txt update - pynetbox==7.3.4 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Requirements.txt update - pynetbox==7.3.4 #151

wants to merge 2 commits into from

Conversation

rondemena
Copy link

Providing fix on version of requirements.txt according to #134

@rondemena
Update requirements.txt
8df205a 
in reference to the netbox-community#134 requirements.txt update need
@rondemena
Merge pull request #1 from rondemena/rondemena-patch-1
7442c4d 
Update requirements.txt
@rondemena
Copy link
Author

rondemena commented Sep 6, 2024 •
edited
Loading

whomever can approve and merge - others likely may benefit from the improvement when attempting to build against using this importer

Should supercede #109 and close the dependabot entry

@danner26 can you check, as you seem assigned to the prior update requested.

@rondemena rondemena changed the title Requirements.txt update Requirements.txt update - pynetbox==7.3.4 Sep 6, 2024
lmdv-julien-kohler
lmdv-julien-kohler approved these changes Sep 17, 2024
View reviewed changes
Copy link

@lmdv-julien-kohler lmdv-julien-kohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, can confirm it work, thanks !

@Playgirlkaybraz11 Playgirlkaybraz11 mentioned this pull request Sep 17, 2024
Merged
bastianleicht
bastianleicht approved these changes Oct 24, 2024
View reviewed changes
Copy link

@bastianleicht bastianleicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worked for me, please merge!

@harryajc harryajc mentioned this pull request Nov 7, 2024
Merged
@tpmeredith
Copy link

Please merge! Mine was failing until I saw I needed to update pynetbox

@lspiehler
Copy link

FYI. The below command can be used to work-around the issue with the docker image.

docker run --rm -it -e "NETBOX_URL=http://netbox:8080/" -e "NETBOX_TOKEN=98765434567890" ghcr.io/minitriga/netbox-device-type-library-import /bin/sh -c 'pip install --upgrade pynetbox && python3 -u nb-dt-import.py'

@harryajc
Copy link

Hi @rondemena,

This PR can now be closed as pynetbox has been updated to 7.4.0 from latest PR merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianleicht bastianleicht bastianleicht approved these changes

@lmdv-julien-kohler lmdv-julien-kohler lmdv-julien-kohler approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rondemena @tpmeredith @lspiehler @harryajc @bastianleicht @lmdv-julien-kohler