Allow dict parameters for primary_mac_address #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Coercing primary_mac_address to str prevents using dict constructs to
point to a specific object in netbox, instead always searching for an
entry with the plaintext mac.
This key for the object is not guaranteed to be unique, resulting in
errors when multiple objects are returned.
Allowing raw parameters permits the following construct to lookup mac
addresses in a different way to get an unique object, for example by id:
```yaml
netbox_device_interface:
primary_mac_address:
id: "{{ mac_address_object_id }}"
```
Fixes: netbox-community#1413
gs-adn
force-pushed
the
fix-duplicate-macs-lookup
branch
from
734f2fc to
d3880fc
Compare
gs-adn
force-pushed
the
fix-duplicate-macs-lookup
branch
from
3aee325 to
8f8bbdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1413
New Behavior
Allowing raw parameters permits the following construct to lookup mac addresses in a different way to get an unique object, for example by id:
Contrast to Current Behavior
Coercing
primary_mac_addressto str prevents using dict constructs to point to a specific object in netbox, instead always searching for an entry with the plaintext mac.This key for the object is not guaranteed to be unique, resulting in errors when multiple objects are returned.
Discussion: Benefits and Drawbacks
This fixes a bug when the same mac address is used by multiple items in netbox 4.2+
Changes to the Documentation
No changes (this allows the already-documented construct described here to be used)
Proposed Release Note Entry
netbox_device_interface: Fix assigning
primary_mac_addressby idDouble Check
develbranch.