-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Display related columns on DeviceComponents table #20344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @llamafilm. The addition of second-order relations like device__location__contacts
and automatic injection of dynamic custom field lookups creates expensive queries that don't scale for large installations and maintenance headaches down the road. These additions are not going to be accepted.
The original FR requested "Device Location and Device Site" but this adds 7+ columns, many more if including all of those dynamic custom fields automatically. Focus on just the two fields you specifically requested in issue #19590. This PR needs to be refactored to address only the specific fields requested in the original FR and to remove the automatic custom field injection and the second-order relation to contacts.
For access to data beyond what's available, users can use Export Templates or the REST/GraphQL APIs.
Ok, I thought you might say that. I understand your concern about complexity and performance with custom fields and contacts. Can we please keep |
While this may seem like a reasonable request, I have to respectfully decline. Our process requires focusing on what was specifically outlined in the original feature request. Staying within the original scope prevents unplanned feature creep and ensures we can properly assess the maintenance commitment for each addition. I realize this seems arbitrary, but it is the process we have. If these additional fields are truly important, please consider filing a separate feature request that outlines the specific use case. |
Fixes: #19590
Add additional columns to all DeviceComponents tables (including Interfaces, Power Ports, Device Bays, etc.)
Device:
Location:
Add additional column to Device Bay table
The custom fields are prefixed with
Device:
orLocation:
. The colon helps differentiate them as custom fields, but I'm open to feedback if there's a better way of labeling.