Closes #20834: Add support for enabling/disabling Tokens #20864
+170
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an `enabled` flag on the `Token` model to allow temporarily revoking API tokens without deleting them. Update forms, serializers, and views to expose the new field. Enforce the `enabled` flag in token authentication. Add model, API, and authentication tests for the new behavior. Fixes netbox-community#20834
Contributor
Author
|
I’ve opened this as a draft PR to get an initial round of feedback on the approach and implementation. Once the changes from #20823 are merged from In the meantime, any early feedback on the model changes, API surface, or tests is very welcome. Thanks in advance for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20834
This PR introduces an
enabledfield on theTokenmodel to allow API tokens to be temporarily disabled without being deleted.Key changes:
enabledBoolean field toToken(defaulting toTruefor backwards compatibility)enabledflag in token authentication so disabled tokens are rejectedenabledvia the token API serializers (including provisioning), allowing tokens to be created and managed in a disabled stateExisting tokens remain enabled by default, so there is no change in behavior until a token is explicitly disabled.
Thanks in advance for reviewing!