Add code coverage report #368
Conversation
Coverage report
Test suite run success67 tests passing in 16 suites. Report generated by 🧪jest coverage report action from 9f8a6c7 |
tsconfig.json
Outdated
| "**/*.test.ts", | ||
| "**/*.test.tsx" | ||
| ] | ||
| "include": ["./src/**/*", "src/vendor/dygraph-c91c859.min.js"], |
There was a problem hiding this comment.
I don't see this dygraph js included in the previous version of the tsconfig.json, what is the reason for this being added now?
.github/workflows/test.yml
Outdated
|
|
||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "12.22.0" |
There was a problem hiding this comment.
@netdata/cloud-fe should the version be that one? It's the same for every other test coverage PR, but previously it was set to node-version: '12.x'
| - name: Run `npm install` | ||
| run: npm install | ||
| - name: Run `npm run lint` | ||
| run: npm run lint |
There was a problem hiding this comment.
This file was deleted, but lint check wasn't moved to the other workflow
There was a problem hiding this comment.
As @dimko mentioned, maybe the check for lint should be moved to the new file as well! 😄
.github/workflows/test.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [master, develop] |
ivangergo3
force-pushed
the
feature/add-coverage-report
branch
from
31d1ff7 to
572be63
Compare
.github/workflows/test.yml
Outdated
| push: | ||
| branches: [master] | ||
| workflow_dispatch: | ||
| inputs: |
There was a problem hiding this comment.
It throws an error here for empty lines!
Maybe this should be removed! 😄
There was a problem hiding this comment.
Good point, removed, update all pending workflows
.github/workflows/test.yml
Outdated
| run: | | ||
| gsutil -h "Cache-Control: max-age=0, no-store" cp /tmp/coverage_report gs://${{ secrets.TEST_AUTOMATION_STORAGE_BUCKET }}/${{ github.event.repository.name }}/coverage_report |
There was a problem hiding this comment.
Also the checks throw an error here for too line size!
There was a problem hiding this comment.
Updated in all pending workflows
ivangergo3
force-pushed
the
feature/add-coverage-report
branch
from
572be63 to
41eb232
Compare
|
@jjtsou, it seems like it was a bad idea to remove the original testing pipeline. Should I put it back or should we run the new with all pull requests? |
|
@novykh , it seems like it was a bad idea to remove the original testing pipeline. Should I put it back or should we run the new with all pull requests? |
|
Run the new on pull_requests. |
Added similar test-coverage report as we have in "cound-frontend"
So from now on, all tests will be executed when a pull request is being created.
And we will publish the results into google cloud, so we can check the current status here
Could you please check this change? And if you have any concerns let me know