feat: certificate-changed event handler #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Obtain or generate TLS certificate with the core helper "get-certificate". - Run the helper as a .service unit that start once when the session boots. - The unit starts before app services.
Replace the obsolete certificate-updated event handler with the new Core 3.6.0 event handler.
DavidePrincipi
commented
Mar 20, 2025
DavidePrincipi
commented
Mar 20, 2025
DavidePrincipi
commented
Mar 20, 2025
|
|
||
| systemctl --user -T try-reload-or-restart phonebook | ||
|
|
||
| systemctl --user -T try-reload-or-restart nethcti-server |
There was a problem hiding this comment.
Note: nethcti-server is a web application that shouldn't use NETHVOICE_HOST name.
Stell0
approved these changes
Mar 21, 2025
Code review Co-authored-by: Matteo Valentini <[email protected]>
Amygos
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Will the files in this directory and the directory itself be deleted during the upgrade procedure?
There was a problem hiding this comment.
This is a very good question. It depends on how many module updates were applied after the core bug fix of NethServer/dev#7058 was received by each cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get-certificatehelper to obtain TLS certificates.get-certificate.serviceunit to run obtain/generate the TLS certificate at boot.References:
See also https://github.com/NethServer/ns8-core/blob/feat-7004/docs/modules/certificates.md#tls-for-other-applications