Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more actionable info for missing primaryRegion #195

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Oct 2, 2024

When using a version of netlify-cli older than 17.23.4, you would encounter this error when using Blobs. The fix is pretty simple but not at all obvious.

See also unjs/unstorage#486 (comment) which prompted this.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 453c254
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/6709317b5ca14a0008efd005
😎 Deploy Preview https://deploy-preview-195--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 2, 2024
@serhalp serhalp marked this pull request as ready for review October 3, 2024 17:14
@serhalp serhalp requested a review from a team as a code owner October 3, 2024 17:14
src/store_factory.ts Outdated Show resolved Hide resolved
@serhalp serhalp requested a review from eduardoboucas October 8, 2024 18:59
@serhalp serhalp force-pushed the fix/make-missing-region-error-more-actionable branch from 54f2b8e to 1990950 Compare October 8, 2024 19:00
When using a version of `netlify-cli` older than
[17.23.4](netlify/cli#6589), you would encounter this error when using
Blobs. The fix is pretty simple but not at all obvious.
@serhalp serhalp force-pushed the fix/make-missing-region-error-more-actionable branch from 1990950 to 9837c23 Compare October 8, 2024 20:42
Co-authored-by: Eduardo Bouças <[email protected]>
@serhalp serhalp merged commit dd517dc into main Oct 11, 2024
9 checks passed
@serhalp serhalp deleted the fix/make-missing-region-error-more-actionable branch October 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants