-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @netlify/blobs to v8 #5756
Conversation
711731b
to
515bc3a
Compare
515bc3a
to
f6b6bb2
Compare
f6b6bb2
to
562b0dc
Compare
7fbe67e
to
b950440
Compare
b950440
to
a0ea528
Compare
|
a0ea528
to
cb3b6c4
Compare
cb3b6c4
to
8b0215a
Compare
b7e9308
to
0823b10
Compare
0823b10
to
32d0798
Compare
All builds failing with the following:
For reference:
|
32d0798
to
915d444
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
// If using the deploy config API or the Frameworks API, configure the store | ||
// to use the region that was configured for the deploy. We don't do it for | ||
// the legacy file-based upload API since that would be a breaking change. | ||
if (blobs.apiVersion > 1) { | ||
storeOpts.experimentalRegion = 'auto' | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to specify reverse condition there by specifying some region for the "else" condition to not cause breaking change this comment is mentioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From netlify/blobs#183
Should you want to update your Blobs client but keep accessing a deploy-scoped store that has been created with an older version, you can use getDeployStore({ region: "us-east-2" }) to ensure you're using the right region.
so something like this:
if (blobs.apiVersion === 1) {
storeOpts.region = 'us-east-2'
}
?
8dd7e98
to
1da95b2
Compare
This pull request adds or modifies JavaScript ( |
This pull request adds or modifies JavaScript ( |
This pull request adds or modifies JavaScript ( |
This pull request adds or modifies JavaScript ( |
For legacy api calls we previously were sending no region in the requests which made use of the default region, but now we explicitly specify the default region in the calls but still end up with the same region in the end. |
This pull request adds or modifies JavaScript ( |
This PR contains the following updates:
^7.4.0
->^8.1.1
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
netlify/blobs (@netlify/blobs)
v8.1.1
Compare Source
Bug Fixes
v8.1.0
Compare Source
Features
Bug Fixes
v8.0.1
Compare Source
Bug Fixes
v8.0.0
Compare Source
⚠ BREAKING CHANGES
Features
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.