Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @netlify/blobs to v8 #5756

Merged
merged 6 commits into from
Mar 21, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 4, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@netlify/blobs ^7.4.0 -> ^8.1.1 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

netlify/blobs (@​netlify/blobs)

v8.1.1

Compare Source

Bug Fixes
  • add missing eu-central-1, ap-southeast-1 and ap-southeast-2 regions (#​214) (0ca340f)

v8.1.0

Compare Source

Features
Bug Fixes
  • add more actionable info for missing primaryRegion (#​195) (dd517dc)

v8.0.1

Compare Source

Bug Fixes
  • 404ing list results should return empty iterators, not throw (#​189) (1da860d)

v8.0.0

Compare Source

⚠ BREAKING CHANGES
Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner July 4, 2024 10:50
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jul 4, 2024
@renovate renovate bot requested a review from a team as a code owner July 4, 2024 10:50
@renovate renovate bot added the javascript label Jul 4, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 4, 2024
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch 2 times, most recently from 711731b to 515bc3a Compare July 22, 2024 13:05
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch from 515bc3a to f6b6bb2 Compare August 5, 2024 12:26
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch from f6b6bb2 to 562b0dc Compare August 26, 2024 20:22
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch 2 times, most recently from 7fbe67e to b950440 Compare September 23, 2024 13:37
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch from b950440 to a0ea528 Compare October 11, 2024 17:05
Copy link

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2024
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch from a0ea528 to cb3b6c4 Compare December 11, 2024 18:34
@renovate renovate bot requested a review from a team as a code owner December 11, 2024 18:34
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 11, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 7, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 7, 2025
@renovate renovate bot force-pushed the renovate/netlify-blobs-8.x branch from 0823b10 to 32d0798 Compare January 9, 2025 21:48
@mrstork
Copy link
Contributor

mrstork commented Jan 9, 2025

All builds failing with the following:

Error: src/plugins_core/blobs_upload/index.ts(54,15): error TS2339: Property 'experimentalRegion' does not exist on type 'GetDeployStoreOptions'.
Error: src/plugins_core/dev_blobs_upload/index.ts(55,15): error TS2339: Property 'experimentalRegion' does not exist on type 'GetDeployStoreOptions'.

For reference:

// If using the deploy config API or the Frameworks API, configure the store
// to use the region that was configured for the deploy. We don't do it for
// the legacy file-based upload API since that would be a breaking change.
if (blobs.apiVersion > 1) {
  storeOpts.experimentalRegion = 'auto'
}

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 10, 2025
Copy link
Contributor Author

renovate bot commented Mar 18, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 18, 2025
Comment on lines 50 to 56
// If using the deploy config API or the Frameworks API, configure the store
// to use the region that was configured for the deploy. We don't do it for
// the legacy file-based upload API since that would be a breaking change.
if (blobs.apiVersion > 1) {
storeOpts.experimentalRegion = 'auto'
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to specify reverse condition there by specifying some region for the "else" condition to not cause breaking change this comment is mentioning?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From netlify/blobs#183

Should you want to update your Blobs client but keep accessing a deploy-scoped store that has been created with an older version, you can use getDeployStore({ region: "us-east-2" }) to ensure you're using the right region.

so something like this:

if (blobs.apiVersion === 1) {
  storeOpts.region = 'us-east-2'
}

?

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 18, 2025
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 21, 2025
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork
Copy link
Contributor

mrstork commented Mar 21, 2025

For legacy api calls we previously were sending no region in the requests which made use of the default region, but now we explicitly specify the default region in the calls but still end up with the same region in the end.

Reference: https://github.com/netlify/netlify-server/blob/539f32e17d30d04efbab1dcc09121d7dcbcbcf53/netliblob/api_v2.go#L283-L287

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork merged commit a71b6ce into main Mar 21, 2025
33 checks passed
@mrstork mrstork deleted the renovate/netlify-blobs-8.x branch March 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adds or modifies js files dependencies Pull requests that update a dependency file javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants