fix(deps): replace noisy deprecated glob@8 with tinyglobby #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
fix/replace-deprecated-glob-v8
branch
from
e38f12d to
8174622
Compare
serhalp
force-pushed
the
fix/replace-deprecated-glob-v8
branch
from
8174622 to
4e392bf
Compare
serhalp
force-pushed
the
fix/replace-deprecated-glob-v8
branch
3 times, most recently
from
b30b386 to
c6969cd
Compare
serhalp
commented
Feb 28, 2025
| const untranspiledFiles = await pGlob(`${path}/**/*.ts`) | ||
| const untranspiledFiles = await glob(`${path}/**/*.ts`, { | ||
| onlyFiles: true, | ||
| followSymbolicLinks: false, |
There was a problem hiding this comment.
Without this, this glob() call hangs — seemingly because it's traversing the whole filesystem 😬
serhalp
commented
Feb 28, 2025
| @@ -10,7 +10,8 @@ export const getTreeFiles = async function (srcPath: string, stat: Stats): Promi | |||
|
|
|||
| return await glob(`${srcPath}/**`, { | |||
| ignore: `${srcPath}/**/node_modules/**`, | |||
| nodir: true, | |||
| followSymbolicLinks: false, | |||
There was a problem hiding this comment.
adding this here and in ./published.ts fixes some tests in tests/main.test.ts that otherwise hang indefinitely (see other comment)
There was a problem hiding this comment.
Although even with this change (which I'm not sure is desirable... we do support symlinks I believe) there are three failing (not hanging) tests. To run those locally:
npm run build && nx run @netlify/zip-it-and-ship-it:test:ci -- tests/main.test.ts
Installing netlify-cli prints a deprecation warning: netlify/cli#7029. I was going to upgrade `glob`, but then I remembered it's a fairly large library, so why not use this as an opportunity to replace it? See https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md. Compare the APIs: - https://github.com/isaacs/node-glob#readme - https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api The only differences are option names, which I've updated. Our uses either hardcode patterns or enforce precisely documented user patterns, so we won't hit any of the limitations of tinyglobby.
serhalp
force-pushed
the
fix/replace-deprecated-glob-v8
branch
from
8aeaf96 to
3514a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Installing netlify-cli prints a deprecation warning. Fixes netlify/cli#7029.
I was going to upgrade
glob, but then I remembered it's a fairly large library, so why not use this as an opportunity to replace it? Seehttps://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md.
Compare the APIs:
The only differences are option names and option defaults, which I've updated.
Our uses either hardcode patterns or enforce precisely documented user patterns, so we won't hit any of the limitations of tinyglobby.
... Then I also saw we're using
fast-globtoo, so I replaced that as well.Related
See also alternative PR upgrading
globinstead: #6143.