Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account envs not showing up in site build #6122

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CalebBarnes
Copy link
Contributor

@CalebBarnes CalebBarnes commented Mar 12, 2025

Summary

Removed siteId from getAccountEnv getEnvelope call.

It looks like this siteId was added here accidentally. This causes site builds to not include account envs because getEnvelope will only get the env vars for that specific site instead of the account.

Fixes CPLA-2583


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

It looks like this siteId was added here accidentally. This causes site
builds to not include account envs because getEnvelope will only get the
envvars for that specific site instead of the account.
@CalebBarnes CalebBarnes requested a review from a team as a code owner March 12, 2025 23:27
@CalebBarnes CalebBarnes self-assigned this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants