Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): retry fetching extensions on failure #6129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanielSLew
Copy link
Contributor

@DanielSLew DanielSLew commented Mar 17, 2025

Summary

Retry fetch to get extensions from jigsaw. If this call fails the build will fail.

Jigsaw calls BB, and we see that there's the occasionally blip in the request there, so this will make fetching extensions succeed more consistently.

@DanielSLew DanielSLew requested a review from a team as a code owner March 17, 2025 20:10
@serhalp
Copy link
Contributor

serhalp commented Mar 17, 2025

btw @DanielSLew we just fixed main a minute ago, just rebase!

@khendrikse khendrikse force-pushed the fix/config/add-retry-fetch-extensions branch from c6bc02f to f85ba26 Compare March 18, 2025 08:06
Copy link
Contributor

@khendrikse khendrikse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR:

We need to fix the tests
I don't think this currently fixes our immediate issue ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants