Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for staging extension api #6141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: add test for staging extension api #6141

wants to merge 4 commits into from

Conversation

khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This tests if the extension api is set properly for staging.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner March 18, 2025 14:24
@khendrikse khendrikse changed the title Cpla 2603/use staging for fetching extensions test: add test for staging extension api Mar 18, 2025
@khendrikse khendrikse force-pushed the cpla-2603/use-staging-for-fetching-extensions branch 2 times, most recently from d998219 to 23a7657 Compare March 18, 2025 14:28
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

serhalp
serhalp previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

serhalp
serhalp previously approved these changes Mar 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@khendrikse khendrikse force-pushed the cpla-2603/use-staging-for-fetching-extensions branch from d9afee0 to 5a9b73b Compare March 21, 2025 09:08
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@khendrikse khendrikse requested a review from serhalp March 21, 2025 14:09
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@khendrikse khendrikse enabled auto-merge (squash) March 21, 2025 15:22
@github-actions GitHub Actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhalp serhalp serhalp approved these changes

Assignees
No one assigned
Labels
Adds or modifies js files automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khendrikse @serhalp @mrstork